Skip to content

mkconcore: exit with an error when a node's source file is missing - #703

Open
yadavchiragg wants to merge 2 commits into
ControlCore-Project:devfrom
yadavchiragg:fix/mkconcore-exit-codes
Open

yadavchiragg wants to merge 2 commits into
ControlCore-Project:devfrom
yadavchiragg:fix/mkconcore-exit-codes

Conversation

@yadavchiragg

Copy link
Copy Markdown

Fixes #702

mkconcore logged "Script ... not found in sourcedir" but continued and exited 0, leaving an incomplete study. It now collects all missing source files, logs them together and exits 1. Pulled containers (labels without a file extension) are unaffected.

Added tests/test_mkconcore_missing_sources.py; the failing case fails without the change. tests/test_e2e_studies.py still passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant